Axetroy
Axetroy
> eventough they seem nice, are they really needed? @n etc.. This seems to make sense. But it does have some scenarios, eg. generating the changelog of the last two...
> Why I come with this: there is no way to generate the log from HEAD to lastTag (without the Tag!)... It should work without any tags. We can add...
In theory, it is possible. But not now, I haven't had time to update recently. PR is welcome, or I will update it in a few days. Any other suggestions...
> Maybe this should be looked into again after the node-ipc incident. Yes, no sandbox, means running is unsafe code. The NPM package has appeared several times, and the vscode...
Personally, I prefer `parseInt` over `Math.trunc` `parseInt` is more readable
The current implementation uses the Identifier node for judgment. However, this node appears in many cases, so it may cause misjudgment. Maybe this isn't a good way to do it.
I have reimplemented it and process almost all Expression and statement. ```ts export interface ExpressionMap { ArrayExpression: ArrayExpression; ArrowFunctionExpression: ArrowFunctionExpression; AssignmentExpression: AssignmentExpression; AwaitExpression: AwaitExpression; BinaryExpression: BinaryExpression; CallExpression: CallExpression; ChainExpression: ChainExpression;...
/cc @fisker @fregante
> The rule should accept and pass all known `window` properties, so it likely needs to import a list from npm. > ### Pass > > ```js > window.innerHeight >...