Brock Wilcox

Results 49 comments of Brock Wilcox

"Currently, the Pugs.hs project exists mainly for historical/archival purposes, not for active development. (Forks are, of course, very much welcome.)" -- I think it isn't expected to compile -- are...

OK -- so I was using `;` and then `(.......)` to take a date/time column and grab off the first 7 characters which happens to be the month, like `2023-12-01...

I didn't know about `curcol`, that's pretty cool! I often need to run `clean-names` but `curcol` will remove some of those use cases. Whelp. This helps the specific use-case I...

I like the second set. You're right that the menu is getting long; this ordering does keep Audit at the top so maybe that'll be fine?

> @awwaiid Not a formal review, but I'll be adding my impressions here. 1/ Let's remove the Items on hand / make a transfer / make an adjustment. Transfers and...

@cielf @dorner Yes please take another look; I addressed much of the feedback. Biggest thing that I'd rather do separate is further refactoring of the specs (removing redundancy, moving system->request)....

Actually I found two issues -- some menu entry current-selection problems and one report that didn't get unified. Fixing...

> I'm OK with moving the spec fixes to a fast-follow... but it really should be a fast follow. We have way too many system specs as it is... I...

@cielf @dorner this is ready for a re-review. I apologize in advance if I missed something you already gave feedback on, I had a hard time keeping track of what...

@cielf menu idea: Move `Inventory Audit` into `Inventory` under `Inventory Adjustment`, still only shown to org-admin ![image](https://github.com/rubyforgood/human-essentials/assets/8642/ed88b6ea-bc28-4565-a527-c80a80a150fa) Move each of the 3 "trend" reports alongside other reports of the same...