Alex W. Jackson

Results 60 comments of Alex W. Jackson

> Also why is `DealsCombatDamageEquippedTriggeredAbility` using `DamagedPermanentBatchEvent` instead of `DamagedPermanentEvent`? Suppose a creature with a "when this deals damage" ability (either its own ability or added by an aura or...

I think `MutateAbility` needs to be implemented as a subclass of `SpellAbility` (compare to bestow) rather than as a subclass of `AlternativeSourceCosts`. The main reason is that casting a creature...

The six conflicting files probably have something to do with the build failing... I finally took a close look at this and I really don't like the approach of replacing...

> Do Condition objects need a copy constructor? Many (most/all?) of the Condition classes in xmage are enums without any fields and without any constructor at all. I believe they...

> Most yes. And I switched over as many more as I could. But not ALL of them are enums. E.g. ManaCondition. I'm definitely not a Java expert, but as...

> Aryel second ability: I believe you should be able to specify X=0 for Aryel Knight of windgrace Created separate issue #8808

Emrakul should not have protection from things like Oblivion Ring (because the spell does not target, a triggered ability of the permanent it becomes does) but it *should* have protection...

We already store the `ApprovingObject` that was used to cast a spell inside the `CAST_SPELL` and `SPELL_CAST` events, and it can be retrieved from those via a rather convoluted process...

> My current saving into the state is not for the chosen ApprovingObject, but the set of all approving object for an ability. > > The set of all possible...

> IIRC, I believe the issue I was that if I try to find the AsThroughEffects outside of `game.inCheckPlayableState() == true`, many of them will change the game state when...