panel-chemistry icon indicating copy to clipboard operation
panel-chemistry copied to clipboard

Support panel 1.0

Open MarcSkovMadsen opened this issue 1 year ago โ€ข 2 comments

This PR adds support for Panel 1.0

  • [ ] Fix "Warning: the global function "jsmeOnLoad" is not defined."
  • [ ] Fix Error: unknown property panel_chemistry.bokeh_extensions.jsme_editor.JSMEEditor.value
  • [ ] merge with Jhsmit:ms_viewer

FYI. @Jhsmit

MarcSkovMadsen avatar May 28 '23 04:05 MarcSkovMadsen

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (da0f009) 83.87% compared to head (25557ff) 88.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   83.87%   88.42%   +4.55%     
==========================================
  Files           9        9              
  Lines         186      190       +4     
==========================================
+ Hits          156      168      +12     
+ Misses         30       22       -8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 28 '23 04:05 codecov[bot]

When running panel serve tests/tests/test_jsme_editor.py --autoreload and opening the app I currently see 2 issues

image

I need to fix these issues

MarcSkovMadsen avatar May 28 '23 04:05 MarcSkovMadsen