Alexander Wels comments

Results 480 comments of


                                            Alexander Wels

Drop RunAsGroup from the exporter pod manifest

Strange the fsGroup should make it so that non root users can access it through the groups they are part of. Does your storage not support fsGroup?

Drop RunAsGroup from the exporter pod manifest

Now CDI should chown to 107 after it is done importing, and IIRC after KubeVirt has started and used a disk image it should have also chowned it to the...

Drop RunAsGroup from the exporter pod manifest

Right, it is interesting this works in CI, since we use a local volume which AFAIK doesn't support fsGroup either. We should probably document that we use fsGroup to give...

Drop RunAsGroup from the exporter pod manifest

Indeed, I believe CI uses cri-o so I would expect that to fail then since we are not specifying the user.

Drop RunAsGroup from the exporter pod manifest

I would think so, @mhenriks any reason you specified runAsGroup?

Drop RunAsGroup from the exporter pod manifest

I am good with the removing of runAsGroup, but @mhenriks wrote the original code so he has more insight there.

Drop RunAsGroup from the exporter pod manifest

/lgtm /retest

Fix flake where cross ns finalizer can't be removed

How about a unit test making sure this is working as expected, like `Should always accept mutate when dv is marked for deletion`?

Fix flake where cross ns finalizer can't be removed

/lgtm @mhenriks any other thoughts?

Using fork of openshift/library-go

/lifecycle frozen