containerized-data-importer
containerized-data-importer copied to clipboard
kubevirt
Using fork of openshift/library-go
Is this a BUG REPORT or FEATURE REQUEST?:
Uncomment only one, leave it on its own line:
/kind bug
/kind enhancement
What happened:
#1091 references a fork of openshift/library-go
Once the following PR is merged, CDI should go back the mainline:
https://github.com/openshift/library-go/pull/540
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
- CDI version (use
kubectl get deployments cdi-deployment -o yaml): - Kubernetes version (use
kubectl version): - Cloud provider or hardware configuration:
- Install tools:
- Others:
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
@mhenriks please take a look and see if we can make the needed methods public in openshift/library-go#540
Closing this since it's been addressed by https://github.com/openshift/library-go/commit/434fa21f5e457d51f436c4b3804c7803db1da42d. Feel free to reopen if necessary.
@akalenyu: Reopened this issue.
In response to this:
/reopen so we remember to get rid of the fork
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Unfortunately have to wait until we move to k8s 1.29 (release-4.16+ branch in library-go) to do this