Alexander Wels

Results 481 comments of Alexander Wels

To make the DCO happy, can you `git --amend -s` the `-s` will sign the commit and make the bot happy.

So I have little to no experience with helm charts. So I can't promise I will maintain it properly. Do we want to create some release artifacts when I release...

Okay I have no issues with this, just one question, what is in the tgz file? Is it just a tarred and gzipped version of the helm chart?

So maybe instead of putting that in the repo, when I make the release, we create the tgz as an artifact, and you can download that to install it?

If you look at https://github.com/kubevirt/hostpath-provisioner/blob/main/hack/release.sh#L45-L59 that is what is called when it is building the release. I don't know what goes in the tgz file, but if you could modify...

I guess you didn't find time, which is fine. Just bumping this so the bot won't start putting stale on it.

Maybe mention that is only needed if your storage class is not recognized by CDI.

CDI maintains a [list](https://github.com/kubevirt/containerized-data-importer/blob/main/pkg/storagecapabilities/storagecapabilities.go) of known provisioners, and it automatically populates the values for those in the StorageProfiles. If you have a provisioner it does not know about, it will...

We also maintain documentation on how to set up storage profiles for provisioners that are not recognized: https://github.com/kubevirt/containerized-data-importer/blob/main/doc/storageprofile.md