kubevirt
Helm-Chart for kubevirt-hostpath-provisioner
What this PR does / why we need it: Helm is a very practical method to deploy, update and rollback applications and operators in Kubernetes. This PR adds a fully functional helm-chart that allows for a single command to deploy, and by specifying your own values.yaml modify any of the values listed in the README.md for the chart.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer: A github-pages deployment which would server as the endpoint for the helm-chart releases would add additional ease of use and quality to the chart. But I leave that up to you if it's something that would interest you :)
Release note:
Adds a helm-chart to the repository. Will have no effect on the functionality of other content. No user action required.
Chart: kubevirt-hostpath-provisioner
AppVersion: 0.18.0
Chart Version: 0.1.0
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign aglitke for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @moffoso. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
To make the DCO happy, can you git --amend -s the -s will sign the commit and make the bot happy.
So I have little to no experience with helm charts. So I can't promise I will maintain it properly. Do we want to create some release artifacts when I release a new version of the provisioner related to the helm charts?
Hey @awels
Unless there are breaking changes to the provisioner, the chart wont need to be updated. The image-tag is set to "latest" per default. (The exeption being if the functionality- of the chart should be extended or improved in some manner)
A release artifact would increase quality of life, especially for example in a CI/CD setup. Optimally the workflow with helm would be that you can add the repository the chart is in e.g:
helm repo add kubevirt https://kubevirt.github.io/kubevirt-hostpath-provisioner
and then install while specifying your own values
helm install kubevirt-hostpath-provisioner kubevirt/kubevirt-hostpath-provisioner -f my-custom-values.yam
The repo/branch containing the helm-packages then needs and index.yaml used for indexing the charts in the repository. index.yaml
apiVersion: v1
entries:
kubevirt-hostpath-provisioner:
- apiVersion: v2
appVersion: 0.18.0
created: "2024-02-21T16:32:46.506729413+01:00"
description: A Helm chart for Kubernetes
digest: 350a43cb10758aad5e46bd5bf1a01a7b727d95536a27cbce0c80a20b73041014
name: kubevirt-hostpath-provisioner
type: application
urls:
- https://kubevirt.github.io/kubevirt-hostpath-provisioner/releases/download/kubevirt-hostpath-provisioner-0.1.0.tgz
version: 0.1.0
generated: "2024-02-21T16:32:46.506427115+01:00"
Branch contents
.
├── index.yaml
├── LICENSE
└── README.md
And finally a release that contains the individual helm-packages.
If that's not something you would want to maintain, that's understandable. In that case a github-release of the chart would suffice for most use-cases. Alternatively I could host a repository for the chart and maintain it. I just thought it could potentially be of interest to you.
Cheers
I did some testing, and found that pvc's would stay pending due to an an error in the rendering of the daemonset manifest. For some reason that I haven't yet got to the bottom of yet. The issue has been resolved, and pv's are provisioned as expected now. -> Bumped the chart version to 0.1.1
Okay I have no issues with this, just one question, what is in the tgz file? Is it just a tarred and gzipped version of the helm chart?
Okay I have no issues with this, just one question, what is in the tgz file? Is it just a tarred and gzipped version of the helm chart?
Indeed it is, it's purely for convenience sake. So that you can install the chart by simply downloading the archive and then running
helm install kubevirt-hostpath-provisioner-0.1.1.tgz
Optionally you can append --namespace yournamespace
So maybe instead of putting that in the repo, when I make the release, we create the tgz as an artifact, and you can download that to install it?
If you look at https://github.com/kubevirt/hostpath-provisioner/blob/main/hack/release.sh#L45-L59 that is what is called when it is building the release. I don't know what goes in the tgz file, but if you could modify that to create the file, and put it in the list of things to push that would be great.
I guess you didn't find time, which is fine. Just bumping this so the bot won't start putting stale on it.
Friendly ping to @kubelize for this PR this feature is very much appreciated :)
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten