PIE icon indicating copy to clipboard operation
PIE copied to clipboard

Small bug in errorify/error.py

Open kevin-parnow opened this issue 3 years ago • 0 comments

Hi, first of all, thank you for releasing your code.

I just found a small bug in errorify/error.py - in the function readn at line 53, the extra "yield clist" outside the for loop will yield a duplicate batch if the number of lines in the file is divisible by the batch size.

(so for a source file of 1,000 lines with batch size 200, corr_sentences.txt and incorr_sentences.txt would have 1,200 lines).

A simple fix is removing the boolean "start" checks and setting "clist = []" after every "yield clist" in the for loop, so if the number of lines in the file is divisible by the batch size, the yield outside of the loop will just return an empty list.

kevin-parnow avatar Sep 22 '20 21:09 kevin-parnow