Avi Kivity

> > > > abort_when_xx sounds like a function, not a class. > > > > I don't know how to feel about this. It looks like a maze of...

> > > > > > abort_when_xx sounds like a function, not a class. > > > > > > I don't know how to feel about this. It looks...

condition_variable can stop on an arbitrary condition. You should be able to write ```c++ auto abort_me = as.subscribe([&] { cv.broadcast(); }); ... co_await cv.when([&] { return as.abort_requested() || other_conditions; });...

> > condition_variable can stop on an arbitrary condition. You should be able to write > > ```c++ > > auto abort_me = as.subscribe([&] { cv.broadcast(); }); > > ......

Please make the title clearer.

> Abort will be requested on the abort_on_expiry::abort_source() either when the timeout expires or abort is requested on the chained abort_source, the earliest of which. This is unclear. What's the...

8.0.0 is less than two years old. I think we can continue to support it for a while, no need to force users to upgrade without a good reason. btw,...

Please change the subject so I'll know what to expect when reviewing.

There's a problem here. Shard 0 could have low-share requests queued. But shards don't communicate the share-mix of the requests, and therefore shard 0 could be preempting high-share work on...

I don't see why multiplying by shares help. The low-share classes can have any number of pending requests, in fact they usually will have a longer queue due to being...