seastar icon indicating copy to clipboard operation
seastar copied to clipboard

abort_on_expiry chaining

Open bhalevy opened this issue 2 years ago • 3 comments

Abort will be requested on the abort_on_expiry::abort_source() either when the timeout expires or abort is requested on the chained abort_source, the earliest of which.

The motivation for this feature is to be able to abort rpc messages either on timeout or via an external abort source (that may be triggered e.g. on shutdown).

bhalevy avatar Jan 23 '23 12:01 bhalevy

Please make the title clearer.

avikivity avatar Jan 23 '23 14:01 avikivity

Abort will be requested on the abort_on_expiry::abort_source() either when the timeout expires or abort is requested on the chained abort_source, the earliest of which.

This is unclear. What's the context here?

The motivation for this feature is to be able to abort rpc messages either on timeout or via an external abort source (that may be triggered e.g. on shutdown).

avikivity avatar Jan 23 '23 14:01 avikivity

@avikivity please see alternative here: https://github.com/scylladb/seastar/pull/1435 these are generic combiners that could be used to combine abort_on_expiry with another abort_source in a generic way and without increasing the footprint of abort_on_expiry

bhalevy avatar Jan 23 '23 15:01 bhalevy