Avi Kivity
Avi Kivity
> > There could be 10k clients connected, easily. > > Perhaps deduplicate it via some hash table + weak pointers. > > Yeah, in some cases we have 1m...
> > Please resolve conflicts and let's see how we address the issue of many clients and their configs - I'd like to see this in 2025.4 and that's not...
I didn't review it closely, but it looks reasonable. Recommend switching to coroutines, the code will be both cleaner and faster.
Did you check that scyllatop still works with Prometheus? Please update the cover letter.
> > Did you check that scyllatop still works with Prometheus? Please update the cover letter. > > I did ages ago ([#17356 (comment)](https://github.com/scylladb/scylladb/pull/17356#issuecomment-1951034816) ). I can check again if...
Since (IIRC) Seastar enables collectd by default, I think you're enabling collectd rather than removing support for it.
We can merge the Seastar change first, and when updating the submodule, drop the collectd command-line switches.
Publishing it doesn't seem trivial. I'll look for an strftrime() replacement that doesn't use the timezone (it will break anyway on non-default locales)
Seems like `__tz_convert` needs the time zone even in UTC, due to the need to figure out leap seconds.
How about: drop the timer, instead each shard checks if duration_cast(now) > duration_cast(_last_time_we_formatted). If so, it reformats locally. Downside is httpd is slower due to the need to read the...