Avi Kivity

Results 1240 comments of Avi Kivity

User: https://github.com/scylladb/scylladb/pull/20480

We don't want to lock to a specific compiler version, but neither do we want to support old toolchains indefinitely. One option is to commit to support the last two...

There's no timing or frame size in the report.

I don't believe compression of a reasonable frame can take 70ms.

lz4 is [reported](https://github.com/lz4/lz4) as compressing > 500MB/s/core (amazing). A 1 MB frame would take 2ms. 70ms at that speed would be 35MB. The reference system runs at 4.9GHz, so maybe...

repair uses rpc streaming. the unit frame there is a row. so if the row is reasonable, so will be its compression time.

> > the unit frame there is a row > > Are you sure about that? > > As far as I can see from the code, the unit is...

Missing documention in cql-extensions.md. ``` 0x04: Custom payload flag. For a request or response frame, this indicates that a generic key-value custom payload for a custom QueryHandler implementation is present...

> I don't know so asking - does it work transparently without a feature flag, across two different Scylla versions (while upgrade is taking place, for example). Since it's a...

There could be 10k clients connected, easily. Perhaps deduplicate it via some hash table + weak pointers.