avigny
avigny
Thanks for your review @jeremiedbb ! I think all the comments have been handled
> CI is failing because this PR introduces many FutureWarnings. You need to check every place where we call `(MiniBatch)NMF` or `non_negative_factorization` where `n_components` is left to its default value...
Last thing, we also need to change the default value of `n_components` from `None` to `"warn"` in the `__init__` function of the two estimators. this will likely create some (I...
ok I'll do that! TIL : adding `-Werror::FutureWarning` allows to have the same results as the CI but locally! great help from https://scikit-learn.org/dev/developers/tips.html#useful-pytest-aliases-and-flags
Should we also add `n_components="auto"` this example? I haven't found other places where the warning could occur https://github.com/scikit-learn/scikit-learn/blob/bcbc2fc3abc32e879fba62486dabe9c05f615e79/examples/compose/plot_compare_reduction.py#L57
> > Should we also add n_components="auto" this example? I haven't found other places where the warning could occur > > Yes, we don't want warnings in the examples either...
Will probably be solved by https://github.com/vllm-project/vllm/issues/11522