Shuhei Kadowaki
Shuhei Kadowaki
`@consistent_overlay` is a subset of what `:executable` implies, and `@consistent_overlay` allows the target methods to be executed at compile time if they are `:foldable`, but I guess I'm missing your...
Thank you for clarifying. That definition of `:executable` sounds to assume that the system for actually executing overlay methods is available for the compiler. Currently, there is no such system,...
CI failures are unrelated to this PR. Going to merge.
@vtjnash what do you think on this?
Well, it would be huge amount of code if we vendor them with all their dependencies? CSV might be small, but Plots and OrdinaryDiffEq come with lots of dependencies.
Yes, Manifest.toml has been checked into BaseBenchmarks.jl, so I think we are going to use a stable dependency graph as far as we don't change it. > And the code...
So after all I think this PR is ready to go as is?
> Wouldn't it make sense to check in a separate manifest for these specific tests? Otherwise it becomes hard to upgrade only the dependencies of BaseBenchmarks.jl itself. ~~Done.~~ EDIT: It...
Can we move this forward without setting up a separate environment for `"inference"` benchmark since I couldn't find a workaround for https://github.com/JuliaCI/BaseBenchmarks.jl/pull/313#discussion_r1161691708?
Okay, so I was unsure how to dynamically activate the environment in runtime of the distributed processes, so I returned to the original single Manifest approach. With this, the tests...