Shuhei Kadowaki
Shuhei Kadowaki
@nanosoldier `runbenchmarks("inference", vs=":master")`
There is one test failure on this PR, so don't merge now.
@nanosoldier `runbenchmarks("inference", vs=":master")`
Planning to conduct a thorough review around tomorrow. On a broader note, maybe relevant to Valentin's PR as well, it might be worth discussing whether this change should be incorporated...
> Does #53219 resolve this? It removes the need to handle code-instances in this location. Probably. I'm looking into it. > In [JuliaDebug/Cthulhu.jl#540](https://github.com/JuliaDebug/Cthulhu.jl/pull/540) I continued using the external code cache...
Yeah I'll work on the PR first and then we only need the test cases from this PR.
I know it might sound like I'm flip-flopping, but I want to move forward with this PR as is. This is because, as things stand post-#52233, virtually all external abstract...
I'll give another review on this PR next week since I'm quite busy until then.
Sorry for being late to give a review. I will try to do this weekend or so.
I apologize for the delay in reviewing; I haven't had time to work on JET recently. The changes you've made look great. Thanks so much for contributing.