Evgenii Averin

Results 26 comments of Evgenii Averin

@atamazov @ppanchad-amd Incorrect records are only present in databases for gfx803, gfx900 and gfx906. Databases for newer GPUs are fine. The format of the record was changed (fixed) in https://github.com/ROCm/MIOpen/pull/343....

Consider, for example, `miopenCreate()` function, which is declared as: ```cpp extern "C" miopenStatus_t miopenCreate(miopenHandle_t* handle); ``` The only information we have about this function is that it has a `C`...

Most of our API are always catch exceptions, they are wrapped in `miopen::try_`. We can add `noexcept` to them at first stage. And then prepare remaining functions for proper exception...

> We may want to have some kind of custom linting to make sure we are always catching the exceptions in our api calls. Maybe something like this: ```cpp extern...

@xinlipn @junliume https://github.com/ROCm/MIOpen/pull/3332 has been merged, this PR can be closed

The ratio `.cpp`/`.cmake` less than 1 :smile:. Do we really need a complete copy of all files from `cmake` directory?

Сomplete review will be tomorrow

@iq136boy Please add also `unit_conv_solver_*` tests for these solvers.

> I'd like to ask how did you check that it's unusable? @CAHEK7 I guess `Static Composable Kernel` was the first attempt to make what we now call the `CK`....