Andrei Vereha

carbonapi: allow to configure CORS options

2

I'm particularly interested in : https://github.com/gorilla/handlers/blob/master/cors.go#L193 We seem to use the CORS middleware: https://github.com/bookingcom/carbonapi/blob/master/app/carbonapi/app.go#L107 But we do not allow configuring it.

summarize: missing aggregations

1

There is list of aggregation supported by graphite: https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/functions/aggfuncs.py We are missinng: `avg_zero`, `stddev`, `range`- and `rangeOf`, `multiply`.

We could limit the length of all logs in a central place. Discussion started here: https://github.com/bookingcom/carbonapi/pull/317#discussion_r493484239

We get this error on startup. It seems that we have two stddevs

I think those are real issues, disabling the linter for now so we can start using it: ``` cache/cache.go:191:10: Error return value of `m_.Set` is not checked (errcheck) m_.Set(&memcache.Item{ ^...

For `asPercent`: https://graphite.readthedocs.io/en/latest/functions.html#graphite.render.functions.asPercent we can have `total1 set to None explicitly when we also have nodes.

For both carbonapi and carbonzipper. That way it's easier to understand what runs where.

What is the maximum size for the compressed and/or uncompressed that this library is supporting? I think it would be nice if we document the desired limits and make the...