Deniz Turgut

Results 127 comments of Deniz Turgut

There is already a [pelican tag](http://stackoverflow.com/questions/tagged/pelican) on StackOverflow.

I'm a little confused here. Why wouldn't you set `SITEURL` as encoded in the first place? ```py SITEURL = 'http://my.site/?app="blog"&path=' ```

Well, there is [`FEED_DOMAIN`](http://docs.getpelican.com/en/stable/settings.html#feed-settings) for cases like that.

Well, then there is the inconsistency of `SITEURL` itself being unescaped but internal replacements escaped. This can potentially break some themes if they were using `SITEURL` verbatim in the templates...

Now, why would you escape `SITENAME`? :) That's just text supplied to the themes to do whatever they want with it. I'm not against this change. I'm just pointing out...

In theory, I'd be in favor of this but I see two problems: * If we do this, then it needs to be required (i.e. `mypy` through CI etc) and...

> My understanding could be incomplete, but I believe Python doesn't care too much about type annotations at runtime, and as such, I'm not sure that the CI chain would...

I'm having trouble understanding the request. What do you expect `pelican` to do with such a setting? For a site with no plugins, what should happen if I set that...

Well, then... Shouldn't this be a job for the plugin that is supposed to take over content generation (i.e. `i18n_subsites`)? Personally, I would not be in favor of an option...

Some problems: - Pretty sure this will fail to include `some.file.with.dots.rst` - You don't actually handle reader selection logic (inside `readers.py:Readers.read_file`). `foo.md.html` would already be selected with previous code, if...