Deniz Turgut

Results 127 comments of Deniz Turgut

Good news: I was able to reproduce the issue. The problem is this one: ```python JINJA_FILTERS = { 'gettext': gettext, 'format': lambda x, *y, **z: x.format(*y, **z) } ``` It...

OK, a bit more good news I suppose. Here is a workaround. First of all, `lambda` is a no-go. It needs to be a function. Extract these functions to another...

> This of course changes the interface...which I'm hesitant to just throw out there. Although, as far as I can tell, nothing in this codebase uses them outside of log.py...

In theory yes, but unless there are changes to the code that is not supported in 3.6, is there a point to drop the support?

> It is working and tested for 3.6 and developers need to make sure that it will work on 3.6 too. That's half of what I was saying. Yes, it...

Why not just amalgamate stuff with symlinks under a folder and use that as `PATH`?

Code is OK but need to actually use it. Otherwise it's just dead code :). Here are some places it can be used: * [test_generators](https://github.com/getpelican/pelican/blob/31b282f3e267a4ce536fcdf598941cc9834c479b/pelican/tests/test_generators.py#L411) * test_utils: [here](https://github.com/getpelican/pelican/blob/31b282f3e267a4ce536fcdf598941cc9834c479b/pelican/tests/test_utils.py#L539) and [here](https://github.com/getpelican/pelican/blob/31b282f3e267a4ce536fcdf598941cc9834c479b/pelican/tests/test_utils.py#L573)....

You can have empty alts, nothing prevents that. `pelican` will show a warning and if I'm understanding the code correctly, all this does is to turn off that warning. However,...

Ah I see. I can't test right now but if filtered warnings trigger `--fatal=warnings` then I'd consider that sort of a bug and rather fix that.

"Yes" on the idea, "not sure" on the implementation :). I was thinking somewhere along the lines of implementing [`callHandlers`](https://github.com/python/cpython/blob/c6e7cf1ee09c88d35e6703c33a61eca7b9db54f3/Lib/logging/__init__.py#L1641) in `FatalLogger` (instead of `warn` or `error`) and raise exceptions...