Adrian Vandier Ast
Adrian Vandier Ast
Hello :) Thanks for the detailed response. The idea with `AnswerSelector(..., cut_first_argument=...)` seems great to simplify the code. The chained sub-objects wild walk and the access to __dict__ may become...
Ok, deciding to cut self a bit earlier doesn't change the way we can retrieve the original function. I didn't see `.original_methods[]` and it may be the cleanest way to...
Hello :) Ok, your comment made things even clearer to me ! You're right, we only need to potentialy discard self in thenAnswer. I've modified the code, it works well....
> Btw, I think the reference to a self is okay here even for classmethods because Python uses __self__ in both cases. Ok, I changed because of classmethod :)
Ok, your implementation with the orignal_method works well. I've added a test on non-strict module function stubbing. But it assumes that if original_method is None, then the new method can...
I try to make a method fail in some cases, and only once. The solution i tired to implement was to thenAnswer the original method after a first mock that...
Ok, I will mix up my answers to be specific :) I need to mock a function but only once. For instance, if there was `thenCallRealMethod`, I would do: ```...
Hello :) Let's clean up that PR commits :D I "think" my git skills are enough so I will do it. For the import reordering, I use [isort](https://github.com/PyCQA/isort). (I'm also...
For isort, I use the last version with the black profile :D But the profile doesn't seem to change anything here. So yes, I think that is the default configuration....
Thanks ! Great review ;)