Augustin Trancart

Results 44 comments of Augustin Trancart

Oups clicked on submit too soon. I'm editing the description.

So these plugins seems to run in some lifecycle steps of webpack not reached by this plugin. Is there any workaround or possibility to have them nonetheless?

Ok after digging a bit more: plugins are indeed run, but not on the file I think. Every individual js files are directly processed by babel, thus they don't go...

Yes the instructions are wrong. If you follow the steps exactly in unicorn you get a 404 on apt-get update because there is no http://ppa.launchpad.net/finalterm/daily/ubuntu/dists/utopic/main/binary-amd64/Packages EDIT it's no big deal,...

> It is not that uncommon to offset the world space for better floating point precision though. This will not be your only problem when you are trying to run...

> So, keep the current behavior but add messages sent with `/msg` to history so that they are visible when opening a query? I'm more in favor of the "don't...

Also, we need to think about `linebreak-style` (which is `off` since https://github.com/iTowns/itowns2/commit/65ccaa7064395bac577414e7eee50976382d5d75). Apparently it causes errors on windows with some settings. Actually, as we use a .gitattribute in the repo...

Referencing https://github.com/iTowns/itowns2/pull/220 here. It will correct `func-names`

Referencing https://github.com/iTowns/itowns2/pull/226

> Looks like we could add >> *.js eol=lf > > to our .gitattributes (in addition to the existing * text=auto) to force the EOL to LF (therefore Maybe we...