dependency-analysis-gradle-plugin icon indicating copy to clipboard operation
dependency-analysis-gradle-plugin copied to clipboard

Kotlin Android project with jvmTarget 11 still sees kotlin-stdlib suggested

Open ZacSweers opened this issue 3 years ago • 1 comments

Build scan link

Plugin version

1.1.0

Gradle version

7.4.2

(Optional) Android Gradle Plugin (AGP) version

7.1.3

Describe the bug

We use jvmTarget 11 in our repo and let KGP apply the stdlib dep for us. With this, it adds the -jdk8 artifact. However, the plugin suggests adding the kotlin-stdlib dep anyway when it should be treated as a bundle dep and/or recognize that the jdk8 artifact includes it.

To Reproduce Steps to reproduce the behavior: See above

Expected behavior

See above

Additional context

{
  "projectPath": ":services:users:test",
  "dependencyAdvice": [
    {
      "coordinates": {
        "type": "module",
        "identifier": "androidx.annotation:annotation",
        "resolvedVersion": "1.3.0"
      },
      "fromConfiguration": "implementation",
      "toConfiguration": "compileOnly"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "com.google.dagger:dagger",
        "resolvedVersion": "2.41"
      },
      "fromConfiguration": "implementation"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "com.google.truth:truth",
        "resolvedVersion": "1.1.3"
      },
      "fromConfiguration": "testImplementation"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "com.slack.lint:slack-lint-annotations",
        "resolvedVersion": "00009"
      },
      "fromConfiguration": "implementation"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "com.squareup.anvil:annotations",
        "resolvedVersion": "2.4.0"
      },
      "fromConfiguration": "releaseImplementation"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "com.squareup.anvil:annotations",
        "resolvedVersion": "2.4.0"
      },
      "fromConfiguration": "releaseUnitTestImplementation"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "io.reactivex.rxjava3:rxjava",
        "resolvedVersion": "3.1.4"
      },
      "fromConfiguration": "implementation",
      "toConfiguration": "api"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "javax.inject:javax.inject",
        "resolvedVersion": "1"
      },
      "fromConfiguration": "implementation"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "junit:junit",
        "resolvedVersion": "4.13.2"
      },
      "fromConfiguration": "testImplementation"
    },
    {
      "coordinates": {
        "type": "module",
        "identifier": "org.jetbrains.kotlin:kotlin-stdlib",
        "resolvedVersion": "1.6.21"
      },
      "toConfiguration": "api"
    },
    {
      "coordinates": {
        "type": "project",
        "identifier": ":libraries:foundation:anvil:injection"
      },
      "fromConfiguration": "implementation"
    },
    {
      "coordinates": {
        "type": "project",
        "identifier": ":libraries:model"
      },
      "fromConfiguration": "implementation",
      "toConfiguration": "api"
    },
    {
      "coordinates": {
        "type": "project",
        "identifier": ":services:users"
      },
      "fromConfiguration": "implementation",
      "toConfiguration": "api"
    }
  ],
  "pluginAdvice": [],
  "shouldFail": false
}

ZacSweers avatar May 06 '22 00:05 ZacSweers

@ZacSweers could you provide the file build/reports/dependency-analysis/usages-dependencies.json, and build/reports/dependency-analysis/bundled-traces.json?

autonomousapps avatar May 06 '22 22:05 autonomousapps