dependency-analysis-gradle-plugin icon indicating copy to clipboard operation
dependency-analysis-gradle-plugin copied to clipboard

Added allowed/ignored variants support

Open tronku opened this issue 2 years ago • 10 comments

Fixes - https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/issues/519

tronku avatar Mar 21 '22 09:03 tronku

Please see failures at https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/runs/5634738312?check_suite_focus=true

autonomousapps avatar Mar 22 '22 07:03 autonomousapps

./gradlew check is failing locally for the main branch too, I don't have experience in gradle testing, can you help please?

tronku avatar Mar 27 '22 04:03 tronku

./gradlew check is failing locally for the main branch too, I don't have experience in gradle testing, can you help please?

Do you have a build scan from your failure?

autonomousapps avatar Mar 27 '22 07:03 autonomousapps

Do you have a build scan from your failure?

Here - https://gradle.com/s/ddfw4lg5mq2ni

tronku avatar Mar 28 '22 06:03 tronku

Ugh, that build scan is broken. Could you provide more information on what is failing for you?

autonomousapps avatar Mar 28 '22 07:03 autonomousapps

check_gradle.txt @autonomousapps check this out, ./gradlew check --info

tronku avatar Mar 29 '22 11:03 tronku

In one of the earlier failures, I see this message:

AndroidTestDependenciesSpec > buildHealth succeeds when a unit test variant is disabled (#gradleVersion AGP #agpVersion) > com.autonomousapps.android.AndroidTestDependenciesSpec.buildHealth succeeds when a unit test variant is disabled (Gradle 7.2 AGP 4.2.2) STANDARD_OUT

    FAILURE: 
    Build failed with an exception.


    * What went wrong:

    A problem occurred configuring project ':proj'.

    > 
    Allowed and ignored variants must be different. Issue found in variant(s): []

I believe the final line there comes from your changes. Does that help?

autonomousapps avatar Mar 29 '22 19:03 autonomousapps

@tronku I'd love this feature on a project I'm working on - would you like any help?

mformetal avatar Aug 09 '22 15:08 mformetal

@autonomousapps Is it ok with you if I take over this PR? I'd love to integrate this plugin's tasks in one of my projects but we have way too many flavors for it to be reasonable on CI for my team members

mformetal avatar Aug 11 '22 15:08 mformetal

@mformetal I need help with creating tests here, tried that but didn't work, can you help with that?

tronku avatar Aug 18 '22 14:08 tronku