Austin Abell

Results 87 comments of Austin Abell

> * `selector_walk.json` needs just a little bit of explainer about which fields are what. (I grok this already; can draft this in a sec.) ipld -> data in Json...

So just to clarify before I try to give details about how benchmarking can be done, the main difference between Ethereum and Ethermint to benchmark is the relative cost of...

related https://github.com/near/near-sdk-rs/issues/559

oh oops, forgot to note the canonical form of these. Let me look more in depth now > Sorry I can't catch this idea. Do we need non-zero the first...

> I just want to sum it up for the future: we decided that we don't need BigDecimal support in the indexer, and thus this PR stuck with some of...

Okay, so the changes for switching to varints are the commits [`21d4857` (#91)](https://github.com/near/borsh-rs/pull/91/commits/21d4857ce419cbdf4aa83cbd90c788024eeb1551) and [`bb625ee` (#91)](https://github.com/near/borsh-rs/pull/91/commits/bb625ee9377b98750768b5180501cd6dc664fe91) It's not clear to me the complexity is worth it, and we could compact...

> @austinabell could you write a public doc comment somewhere which specifies how exactly we serialize things? This is two kill two birds with one stone: > > * make...

> Looks good! We'd have to update [how we call it](https://github.com/near/near-api-js/blob/master/src/account_multisig.ts?rgh-link-date=2022-04-01T17%3A43%3A11Z#L354) in `near-api-js` due to the interface change but aside from that we should be good to go. Very quick...

~~hmm, hold up on merging this though, adding workspaces tests seemed to brick the build -- diving into why that affected it~~ fixed

> @austinabell after further discussion with the team, we think it would be better to leave the `clean` method signature as it currently is due to serialization issues with array...