Martin Auswöger comments

Results 436 comments of


                                            Martin Auswöger

Backend readonly mode does not work for all widgets

> How can we _fully support it for all fields_ if the HTML standard does not? See https://github.com/contao/contao/issues/4868#issuecomment-1264333797 for checkboxes `onclick="return false"` should be sufficient.

Undefined constant "Contao\BE_USER_LOGGED_IN" on 404 page

So we need to call `framework->setLoginConstants()` in the `PrettyErrorScreenListener`?

Enable login rate limit

Shouldn’t we remove our own logic then so that these mechanisms don’t interfere with each other? https://github.com/contao/contao/blob/09696f510b318cd94c594d9aa83a49d040c2a9f6/core-bundle/src/Security/User/UserChecker.php#L50

Insert-Tag {{insert_content}} ignoriert invisible flag

For legacy content elements the visibility is checked here: https://github.com/contao/contao/blob/6646d850737f9f718a296a3e952552e171512f84/core-bundle/contao/elements/ContentElement.php#L239 But this seems to be missing from the `AbstractContentElementController`. We’d also like to discuss if this should be handled from...

Security question hash saved in HTTP cache

> A page with a form containing a security hash should probably be private in the first place, right? I don’t think so. The hash just has to match the...

Add id check to dc table

Casting `intId` to integer (in DC_Table, not DC_Folder) would be great I think. But are we sure that DC_Table cannot be used with string primary keys?

Dateiverwaltung: Markierung wichtiger Teil des Bildes fehlerhaft

See #5437

Allow creating modern templates from within the back end

I think a simple solution as a bug fix for 5.0 would be great. Creating the file with just the `{% extends … %}` line would be enough IMO. All...

Make forms optional instead of required

I don’t think we should change the logic of the form generator here. You can mark optional fields via placeholder or add an “(optional)” to the label and still mark...

Add class to backend login

> The pull request needs to be rebased onto the correct branch. Couldn’t this also be seen as a bugfix? Because it is currently not possible to distinguish between backend...