Iwan Aucamp

Add class name support for CallsiteParameterAdder

3

It may be nice to include support for class name in `CallsiteParameterAdder`, not sure how practical/easy it will be though, or how reliable it is to get the class name...

rclone logs password value if set via environment variable

9

#### What is the problem you are having with rclone? Rclone writes the obscured SFTP password to log (i.e. stdout) when running with: ``` RCLONE_CONFIG_SRC_PORT=22 RCLONE_USE_JSON_LOG=true RCLONE_LOG_LEVEL=DEBUG RCLONE_LOG_FORMAT=date,time,microseconds,pid,longfile,shortfile,UTC RCLONE_CONFIG_SRC_HOST=example.com RCLONE_CONFIG_SRC_USER=username...

No validation for google_compute_network resource name

6

### Community Note * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request. * Please do...

Type checking as part of the CI pipeline

4

Maybe I missed something, but I don't see any type checking running as part of the CI pipeline, should this not be added to ensure added type hints are correct?

fix: handling of Literal datatype

1

# Summary of changes Check datatype against `None` instead of checking it's truthiness (i.e. `if datatype is not None:` instead of `if datatype:`). Checking truthiness instead of `is not None`...

[DO NOT REVIEW] Add a bunch of typing

3

This is a branch I'm maintaing with a bunch of typing, I'm planning to integrate it with master in parts, anyone is welcome to have a look but most of...

Fix Liskov substitution principle violations in sub-classes of Graph

6

We have many liskov substitution principle violations in the Graph class hierarchy, ideally this should be fixed in the next major version.

Fix PEP-8 naming violations

1

We have many PEP-8 naming violations that should be fixed in the next major version.

SPARQLUpdateStore has two open methods

4

https://github.com/RDFLib/rdflib/blob/0856ac8842697fb00199d2beb9ae1ee5b9152c68/rdflib/plugins/stores/sparqlstore.py#L445 https://github.com/RDFLib/rdflib/blob/0856ac8842697fb00199d2beb9ae1ee5b9152c68/rdflib/plugins/stores/sparqlstore.py#L554 https://github.com/RDFLib/rdflib/blob/0856ac8842697fb00199d2beb9ae1ee5b9152c68/rdflib/plugins/stores/sparqlstore.py#L591

We don't include the changelog in our docs (i.e. https://rdflib.readthedocs.org/) but we really should.