Iwan Aucamp

Results 286 comments of Iwan Aucamp

I think your expectaion is reasonable @edmondchuc - but changing this will be a breaking change, so should be targeted for 7.x, see https://github.com/RDFLib/rdflib/pull/2108 for some options.

- Closed by https://github.com/RDFLib/rdflib/pull/2557

@jclerman yes it should be closed, especially after this was merged: - https://github.com/RDFLib/rdflib/pull/2365

https://github.com/RDFLib/rdflib/issues/2123#issuecomment-1475448693 > One option to solve this is to enforce that `rdflib.terms.Literal` always has a datatype, but then we won't be able to support RDF 1.0 anymore. I'm somewhat okay...

Only a partial response, will respond to the rest when I have more time: > I tend to expect single-leading-underscore functions to _not_ be imported into other modules, but `_is_valid_uri()`...

Fix is more or less ready, please have a look: - https://github.com/RDFLib/rdflib/pull/2406

A bit of a pile on, but it would be really nice to still have support for older versions of [protobuf](https://pypi.org/project/protobuf/) as tensorflow still only supports protobuf

> I believe that mypy_protobuf should work by installing mypy_protobuf in a separate venv. That is an option, at the moment I'm using poetry to manage my dev tools though...

bit of a hack I guess, but I created a tox environment for mypy-protobuf now: ``` # https://tox.wiki/en/latest/config.html # https://tox.wiki/en/latest/user_guide.html [tox] envlist = isolated_build = True [testenv:tool-mypy-protobuf] skip_install = True...

All the proto files are in here: https://github.com/aucampia/issue-20221116-python_protobuf_cloudevents/tree/a245d29c2b1600b6580c6db861b4b715e72b9b51/spec/proto but the file that the problems originate from is `spec/proto/example/v1/messages.proto` and its content is: ``` syntax = "proto3"; package example.v1; import "io/cloudevents/v1/cloudevents.proto";...