Joe Atzberger

And what does `private` mean in a non-class non-module position? https://github.com/samvera/active_fedora/blob/v11.0.1/lib/active_fedora/rake_support.rb#L36 Is the author trying to do OO or not?

This surprised me today. ```ruby ActiveFedora::File.find 'whatever_the_hell' => # ``` Basically, we treat `find` as `find_or_new` here. That seems like really bad idea. Throwing exception would definitely be preferable to...

@jcoyne simple question, where does `ActiveFedora::File` get `.find` from? Ancestors look like: ```ruby ActiveFedora::File ActiveFedora::Scoping::Named ActiveFedora::Scoping::Default ActiveFedora::Scoping ActiveFedora::Inheritance ActiveFedora::Identifiable ActiveFedora::AttributeMethods::Dirty ActiveFedora::AttributeMethods::Write ActiveFedora::AttributeMethods::Read ActiveFedora::File::GeneratedAssociationMethods # ActiveFedora::AttributeMethods ActiveModel::Validations::Callbacks ActiveFedora::Callbacks # ActiveModel::Dirty ActiveModel::AttributeMethods...

I understand the motivation. The code is still wrong, as far as modularity and conventionality goes. The conventional approach would be to have each concrete module include the abstract one...

Example from: https://github.com/samvera-labs/hyrax/issues/799 [Blacklight::Solr::SearchBuilderBehavior](https://github.com/projectblacklight/blacklight/blob/master/lib/blacklight/solr/search_builder_behavior.rb#L7), basic example: ```ruby class MyClass include Blacklight::Solr::SearchBuilderBehavior end ``` If you do that in console, you won't even get to do `MyClass.new`. Instead: ``` NoMethodError: undefined...

@jcoyne Right, that *intent* (or foreknowledge) is the anti-pattern. The module is still wedded to the class. I appreciate the contextualization, but I am not interpreting that as excusing the...

Is this a request for documentation or is there additional code that needs to be integrated for the feature to be exposed in a Blacklight app?

@projectblacklight/contributors needs milestone

We were able to integrate Keycloak with a SAML backend "Identity Provider", with this as a starting point: https://www.keycloak.org/docs/6.0/server_admin/#saml-v2-0-identity-providers Had to add some attribute mapping to get autoprovisioning (first name,...

I agree w/ your direction here.