Mikhail

Results 9 comments of Mikhail

Overall looks good, mostly minor issue. The one is principal is https://github.com/brave/brave-core/pull/14271#discussion_r946402777

@mihaiplesa It's hard to say. The code definitely needs a refactoring but before we need to find a new owner. I will preferrer to save this branch for some time.

an upstream bug: https://issues.chromium.org/issues/329580320

The upstream bug is fixed and Chromium claims it helps to resolve most of the issues for them. However, it cant still reproduce the issue on a recent nightly (cr126)...

I've managed to get the correct stack. It matches the crash dumps and the details in the chromium issue. [trace_with_heap_dump.json.gz](https://github.com/user-attachments/files/15892837/trace_with_heap_dump.json.gz)

I've pushed CL to upstream that should improve the situation: https://chromium-review.googlesource.com/c/chromium/src/+/5670619/1 However, despite Chrome also has this issue, it is more severe in Brave Browser. The reason is an avalanche...

The crash stack is: ``` [ 00 ] ImmediateCrash() ( immediate_crash.h:176 ) [ 01 ] CheckFailure() ( check.h:212 ) [ 02 ] net::SpdySessionPool::MapKeyToAvailableSession(net::SpdySessionKey const &,base::WeakPtr const &,std::__Cr::set) ( spdy_session_pool.cc:626 )...

Could someone of the reporters verify that Swizzin web app works well using [the recent nightly build](https://github.com/brave/brave-browser/releases/tag/v1.69.21)?

@vadimstruts Looks like the PR does a lot of work on UI thread (parsing the data from APIRequestHelper, processing data in Rust) Are there any reasonable limits for the data...