Adam Hoyle
Adam Hoyle
hey @tomhughes thanks for your super fast reply. I'm glad at least _some_ of it was sane 🥳. I'll refactor the model part into something more Ruby appropriate. Bear with...
@tomhughes apologies for the delay getting back to this - I've refactored the data stuff in a way that I _think_ is an improvement. At any rate I'm a bit...
@tomhughes / @gravitystorm, I realise you are both incredibly busy, but it's been a while and I'd really like to get feedback as to whether this approach is viable from...
> One further thing - please run rubocop! My code editor lights up with all warnings that it highlights, and it makes my life a little bit easier if they...
Thanks for enabling me to run the tests @tomhughes! Does anyone reading this know why **Tests / Ubuntu 20.04 Ruby 3 (pull request)** might be failing - looking at the...
hey @gravitystorm, I hope you are well. While we're waiting for @tomhughes to have some free time to review this PR, would it be possible to share any examples of...
> I think the answer to this bit is `I18n.backend.store_translations`, which is [described in the i18n documentation](https://guides.rubyonrails.org/i18n.html). Amazing - `I18n.backend.store_translations` looks like exactly what I was hoping existed 🤩
I've refactored to use `I18n.backend.store_translations` and it's massively reduced the complexity of the code. I'm so much happier with it now.
Hi @gravitystorm I've implemented all of the suggested changes 😎 Before I move it to a full PR I'd really appreciate your thoughts on: * What kind of tests I...
hey @gravitystorm and @tomhughes, It's been a couple of weeks, so I just wanted to see if you had any thoughts on the above so that I can progress this...