nyxt icon indicating copy to clipboard operation
nyxt copied to clipboard

Replace `extended-command-source` by separate command akin to `eval-expression`

Open aadcg opened this issue 1 year ago • 2 comments

It's not sensible that execute-command also evaluates sexps. Instead, there should be a separate command for that purpose.

Not to mention that the logic behind extended-command-source (its prompter:filter-preprocessor) is an abomination.

aadcg avatar Aug 09 '24 10:08 aadcg

Hello, I'm planning to contribute to this browser. I've been using it on and off for the last few years. I'd like to be assigned for this issue, and @aadcg can you describe in a bit more detail where to look (file in the source) for the specific issue and what the new command must also do?

divyaranjan1905 avatar Aug 17 '24 00:08 divyaranjan1905

Hi @divyaranjan1905! Thank you for the interest.

can you describe in a bit more detail where to look (file in the source)

See source/command-commands.lisp.

what the new command must also do?

As described in the issue's title, inspiration can be taken from Emacs' eval-expression. There's no need to implement completion or other fancy things.


Let me know if this helps.

aadcg avatar Aug 21 '24 18:08 aadcg

The command has been deleted in 08ba7e6b699f08c2fe5aa4d06bf99167b1dc6544. Patches welcome to add a command to eval sexps.

aadcg avatar Feb 28 '25 15:02 aadcg