nyxt icon indicating copy to clipboard operation
nyxt copied to clipboard

secondary keybinding not displaying in internal page *help-bindings*

Open lansingthomas opened this issue 1 year ago • 1 comments

Describe the bug reload-current-buffer has two keybindings in CUA mode default. f5 and Ctrl+r

the Describe Bindings page only displays the first binding (in this case f5)

I care about this as I try to find open bindings for other things. This is causing other error states.

Precise recipe to reproduce the issue

Information Nyxt version 3.11.8 Flatpak install Ubuntu

lansingthomas avatar Aug 07 '24 22:08 lansingthomas

@lansingthomas thanks for reporting.

The right way to fix this is to do a deep refactor in the 4-series. We have 4 ways to fetch the keybindings. See binding-keys, describe-bindings, command-attributes and describe-function. binding-keys should be refactored to be used in all use-cases.

Additionally, describe-prompt-buffer could use a deep refactor, while ensuring that it re-uses some of the keybindings display logic.

aadcg avatar Aug 08 '24 11:08 aadcg