Creating a buffer for internal page doesn't branch history

[aadcg]

Currently when a user visits the changelog and clicks a link to slot, issuing history-backwards is a no-op since there are no known places to return to. From the user's perspective, this is very confusing. In other words, when (current-buffer) is an internal page, the invocation below returns nil. I'm not sure if this is a bug or a feature that is missing.

(with-history (history (current-buffer))
  (let ((owner (htree:owner history (id (current-buffer)))))
    (htree:all-parents history :owner owner)))

It would be nice if all internal pages had an isolated container for history entries.

[Ambrevar]

They are supposed to, it's almost certainly a bug and may be related to #3051.

[aadcg]

They are supposed to, it's almost certainly a bug and may be related to #3051.

I thought so too, but I created separate issues nonetheless.

[aartaka]

clicks a link to slot

Does this also happen with link hints? If not, that's #2950/#2634. Clicks not being properly inspected is a huge problem with our history mechanism, because there's too much noise/vacuum link clicks create.

That's why I really want to merge #2950—it fixes lots of problems, while only introducing a minor UX cludge for a rare use case.

---

Let's close this, unless it doesn't work with link hints too.

[aadcg]

@aartaka, this issue is not related to that.

Here's a simple recipe:

• nyxt --failsafe
• M-x changelog
• M-x describe-command RET changelog
• M-x history-backwards
• "No backward history".

[aartaka]

Ah, it's this one. Then, the problem is the set of situations where we branch the history out from the current buffer. Now, it seems, history doesn't branch if we create an internal page. I guess it should.

Still, it's not related to internal pages themselves, it's about our history management not working to its full potential in regards to intuitiveness 😃