nyxt icon indicating copy to clipboard operation
nyxt copied to clipboard

Published 20 hours ago • verified publisher icon atlas-engineer

Dangling `windows` when starting Nyxt from REPL multiple times

Open aadcg opened this issue 1 year ago • 8 comments

Commit 30c91a5be (in the context of PR #2666) introduces a bug.

Steps to reproduce:

  • (asdf:load-system "nyxt/gi-gtk")
  • (nyxt:start :failsafe t)
  • notice that a single Nyxt window exists
  • (nyxt:quit)
  • notice that no Nyxt windows exist
  • (nyxt:start :failsafe t)
  • notice that 2 Nyxt windows exist

@Ambrevar could you please fix it?

aadcg avatar Dec 23 '22 13:12 aadcg

I can't reproduce on 27ef18ae8349916be51a093952195ddf23545c10. Can you @aadcg?

Ambrevar avatar Jan 04 '23 09:01 Ambrevar

Yes. Are you on EXWM? Are you double checking all of the existing EXWM buffers by calling ibuffer in Emacs?

aadcg avatar Jan 04 '23 09:01 aadcg

I could reproduce now, it seems that the bug does not always happen, there is a race condition.

Ambrevar avatar Jan 04 '23 09:01 Ambrevar

Oh, I see. I guess my machine is less powerful than yours, since I always get this bug.

aadcg avatar Jan 04 '23 10:01 aadcg

PR #2730 didn't fix this issue on my end.

aadcg avatar Jan 06 '23 10:01 aadcg

@aartaka can you reproduce this bug?

aadcg avatar Jan 06 '23 10:01 aadcg

@aartaka can you reproduce this bug?

Oh wait, I can! Using :failsafe t seems to indeed spawn additional windows 0_o

aartaka avatar Jan 09 '23 08:01 aartaka

Could you investigate? Hard for me to reproduce, so it's probably a race condition and something to do with class update.

Ambrevar avatar Jan 10 '23 09:01 Ambrevar