nyxt icon indicating copy to clipboard operation
nyxt copied to clipboard

Make decide-policy error debugging easier

Open hendursaga opened this issue 1 year ago • 6 comments

On latest commit, there's a TODO at https://github.com/atlas-engineer/nyxt/blob/master/source/renderer/gtk.lisp#L389 for "[d]on't automatically call the restart when from the REPL?" I uncommented the next two lines, deleted the third, and set *run-from-repl-p* to T - perhaps this REPL behavior should be the default? Or something else..?

hendursaga avatar Jul 15 '22 18:07 hendursaga

Do you like this behaviour? The reason it's commented is mostly because it's untested. If you've got a good use case for it and do not see any downside, we can apply this change indeed.

My main concern is that it could get triggered too often.

Ambrevar avatar Jul 18 '22 12:07 Ambrevar

it could get triggered too often.

Hmm, didn't think of that. Personally it didn't seem like it got triggered (accidentally, at least) too often. I'm not sure what to do, then.

hendursaga avatar Jul 18 '22 18:07 hendursaga

It's probably fine to enable it then :)

Ambrevar avatar Jul 19 '22 03:07 Ambrevar

As mentioned in https://github.com/atlas-engineer/nyxt/issues/2472#issue-1313738671, the steps above that I used before successfully causes Nyxt to crash immediately now. This is with and without replacing those lines.

Perhaps I should open a separate issue, but currently whenever I open up a site like https://SongMeanings.com and try to search, it gives me something like...

<WARN> [14:13:15] Warning: Error in FFI method: The value
  ((&quot;q&quot; . &quot;Hello World&quot;))
is not of type
  (OR STRING (SIMPLE-ARRAY (UNSIGNED-BYTE 8) (*)))
when binding QURI.DECODE::DATA

... and then when I try the aforementioned steps, it turns into something like...

<WARN> [14:22:29] Warning: Error on GI-GTK thread: The value
  ((&quot;query&quot; . &quot;Hello World&quot;) (&quot;type&quot; . &quot;all&quot;))
is not of type
  (OR STRING (SIMPLE-ARRAY (UNSIGNED-BYTE 8) (*)))
when binding QURI.DECODE::DATA

So, from an FFI error to a GI-GTK thread error. I don't know what to do to proceed debugging this.

hendursaga avatar Jul 23 '22 18:07 hendursaga

Does disabling reduce-tracking-mode help? If so, I might've messed thing up while refactoring anti-tracking query cleaning :D

aartaka avatar Jul 23 '22 20:07 aartaka

@aartaka it appears that particular error is caused by that, yes, but the fact remains, for other similar classes of bugs, I can't attempt debugging without crashing Nyxt..

hendursaga avatar Jul 23 '22 21:07 hendursaga