nyxt icon indicating copy to clipboard operation
nyxt copied to clipboard

Move class-star to a separate repository

Open Ambrevar opened this issue 3 years ago • 5 comments

I've asked defclass* upstream if they are still maintaing their package and would accept to merge the class* changes.

If not, then I suggest we publish this library, it's too useful to be left inside Nyxt :) @jmercouris: Shall I move it to @atlas-engineer or to @ambrevar?

Ambrevar avatar Jan 20 '21 11:01 Ambrevar

I would suggest all libraries we build in the context of Nyxt go to the atlas engineer repository, so that our community contributions are evident

jmercouris avatar Jan 20 '21 12:01 jmercouris

Good news, upstream has accepted most of my patches. Only one remains dangling: https://github.com/hu-dwim/hu.dwim.defclass-star/pull/3

If it gets merged, then we can switch to the latest version of hu.dwim.deefclass-star.

Ambrevar avatar Feb 02 '21 18:02 Ambrevar

For now Quicklisp only publishes the stable tag of https://github.com/hu-dwim/hu.dwim.defclass-star, so we need to wait until this gets updated before we can get rid of our class-star library.

Ambrevar avatar Mar 24 '21 09:03 Ambrevar

Maybe Quicklisp won't update the package anytime soon, so instead I suggest using a submodule for defclass-star.

Then we can remove libraries/class-star and define our own define-class in Nyxt that automatically sets the user class when the class name is exported.

Ambrevar avatar May 19 '21 10:05 Ambrevar

When we do, rename defcondition* to define-condition*.

Ambrevar avatar Jul 30 '22 02:07 Ambrevar