Andrew Case

Results 145 comments of Andrew Case

@ikelos I am going to pull the parity label off this one but leave it open. Your PR helps one case, but we didn't get to do the locking which...

Hm yea, we (the core team) need to figure it out better then and document it as we have been telling people in workshops, since it seems to work in...

Follow up: the reason we use this feature is that scanning to find the version is really slow when running 15-20 plugins separately versus with --config you get plugin results...

That is an interesting thought too. Should these plugins have had those requirement(s) all along? I think only ikelos knows this though.

> @ikelos comment here though: > > > it's really fluke that these all work (because all plugins by convention alone, use the same name for their ModuleRequirement, and for...

I am going to rewrite this a bit based on discussion from this weekend and what you said in this ticket, but I did want to point out early that...

ok @ikelos I reworked all of this to match where we have the staticmethods and classmethods and each plugin has its own run and generator.. removing the inheritance lets the...

> If you get this past the black formatting, it can be merged now, thanks for the changes... fixed now

Feedback addressed @ikelos . I added yield from anywhere feasible plus the primary layer name passing.