Attila T. Áfra

Thanks! With ROCm 5.1.1 it does not fail here anymore but now it fails when linking. For example: ``` /snap/cmake/1082/bin/cmake -E cmake_link_script CMakeFiles/HIPOnlyMathFunctions.dir/link.txt --verbose=1 /opt/rocm-5.1.1/llvm/bin/clang++ --offload-arch=gfx1030 CMakeFiles/HIPOnlyMathFunctions.dir/main.hip.o -o HIPOnlyMathFunctions clang-14:...

Hi, It is common practice in principled materials to control the reflectance of the layers independently, ignoring the IOR of the layer below/above. This makes the material parameters more artist...

Another similar example is implementing efficient convolution kernels using different block sizes. The following code could be significantly cleaned up: https://github.com/OpenImageDenoise/oidn/blob/v2.2.0-rc/devices/cpu/cpu_conv.ispc https://github.com/OpenImageDenoise/oidn/blob/v2.2.0-rc/devices/cpu/cpu_conv_compute.isph https://github.com/OpenImageDenoise/oidn/blob/v2.2.0-rc/devices/cpu/cpu_conv_compute_block.isph

This is great news, thanks! Open Image Denoise doesn't use short vectors, so `int` and `enum` paramer type support would be sufficient.

It's just a warning, linking is successful anyway.

Forcing the old linker with `-Wl,-ld_classic` makes the warnings disappear.

The environment is very likely critical to reproduce this issue. I can't reproduce it if I build OIDN on a machine with older Xcode, but I can reproduce it on...

It seems the issue happens only when using the new linker in Xcode 15. Forcing the old linker with `-Wl,-ld_classic` fixes it. The instructions generated by ISPC look correct but...

I don't really like the `ISPC_PACKED_FACTOR_BYTE` uniform parameter. I find it too verbose, and gives the impression that this value could be a variable, while in practice it should be...

So based on HLSL, here's what I propose instead: ``` varying uint32 dot4add_u8packed(varying uint32 a, varying uint32 b, varying uint32 acc); varying int32 dot4add_i8packed(varying uint32 a, varying uint32 b, varying...