Aswin Karthik

Results 10 comments of Aswin Karthik

Update: For the vendor directory of talisman ``` real 0m2.707s user 0m11.829s sys 0m0.219s ``` Current stats: GetDiffForStagedFiles: git repo additions took 448.128554ms detector.FileNameDetector took 67.564441ms *detector.FileContentDetector took 246.185828ms ***detector.PatternDetector...

In Golang, nulls cannot be stored as a string. It is read as an empty string by the csvreader. Only a pointer can store nils. I will think about a...

While validating both the configuration files, there is a check for the column cout [here](https://github.com/aswinkarthik/csvdiff/blob/master/cmd/config.go#L56) How about ``` csvdiff base.csv pk.csv --columns 0 ``` This means only one column is...

I was thinking of introducing a feature where if we specify columns flag, we dont need to check if columns count match. All that matters is if the specified column...

Will you be able to share some stats about this: 1. How big was base and delta file? 2. Did it finish? If so, how much time did it take?

> But in reverse case (when standby restarts earlier then master after decreasing parameter) standby node will see the old value of parameter on master forever and cannot restart normally....

Parsing also fails ```rust DateTime::parse_from_str("2018-08-08 10:10:10 GMT", "%Y-%m-%d %H:%M:%S %Z") // bad or unsupported format string ```

Lets go with one go-routine per element and no need for a way to control the parallelism.

Could you resolve the conflicts and update the PR?

Flatten can easily be implemented using consecutive `append` calls. I am having doubts if flatten will help @arunvelsriram