Andreas Süßenbach
Andreas Süßenbach
With the latest changes, I get this validation layer error: `Validation Error: [ VUID-VkGraphicsPipelineCreateInfo-multisampledRenderToSingleSampled-06853 ] | MessageID = 0x3108bb9b | vkCreateGraphicsPipelines(): pCreateInfos[0].pMultisampleState->rasterizationSamples (1) does not match the number of samples...
When I start this sample, I get this error message: `Validation Error: [ VUID-VkRenderingInfo-pNext-pNext ] Object 0: handle = 0x2cff0107020, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xdc5df1d | vkCmdBeginRenderingKHR(): pRenderingInfo->pNext...
> On which platform do you test? I see that on Win10, using an NVIDIA GPU, Vulkan SDK 1.3.280. And yes, that extension seems to be available on some mobile...
As stated half a year ago, you nicely sort the triangles into four different buckets, but use just two different pipelines to render them: all opaque and transparent triangles are...
Would you mind to resolve this issue like it's done in #833?
Looks good now, and works. Would be great, if you could adjust hpp_dynamic_uniform_buffers accordingly.
Totally agree, that `Drawer` and `HPPDrawer` are redundant. `HPPDrawer` was just introduced, when `HPPGui` was introduced, even though the `Drawer` is completely vulkan-agnostic. I think, the best approach would be...
After thinking about your changes yet another time, I would propose the following adjustments: - As the `available_shaders` need to be in the `vkb::Application` (because `vkb::Platform::get_app`, called by `plugins::RealTimeShaderSelection::on_update_ui_overlay` can...
While merging with main, some error might have happen. In `HPPDynamicUniformBuffers::prepare`, some code has been duplicated. Instead of ``` if (HPPApiVulkanSample::prepare(options)) { prepare_camera(); generate_cube(); prepare_uniform_buffers(); descriptor_set_layout = create_descriptor_set_layout(); pipeline_layout =...
Maybe we can add a CI step, that actually formats the files? See https://github.com/marketplace/actions/clang-format-action, for example.