halotools
halotools copied to clipboard
astropy
Python package for studying large scale structure, cosmology, and galaxy evolution using N-body simulations and halo models
I'm not 100% sure this is a bug, but let's discuss that. SubhaloPhaseSpace uses sign_pbc (or it's internal version _sign_pbc) to calculate relative phase-space positions between subhalos and host halos....
The name change in #887 and #888 should be better explained so that users can understand the connection between the old and new algorithm. It may also be worth mentioning...
Current docs only list the default option for the `add_subgrid_noise` argument of `conditional_abunmatch` as "recommended" without evidence.
In the bin-free CAM implementation introduced in #888, the first and last `nwin` elements are treated using the naive pure python algorithm. For typical `nwin` values of a few hundred,...
The `conditional_abunmatch` algorithm introduced in #888 is purely serial, but in principle the algorithm is trivially parallel.
I don't think `marked_cpairs.conditional_pairwise_distances.pyx` is used in the package. Any qualms with removing it? @aphearin
All basic examples notebooks use numpy but there is not a numpy import line. all examples : halotools/docs/notebooks/galcat_analysis/basic_examples/galaxy_catalog_analysis_tutorial*.ipynb call numpy routes as np.somefunction They are missing the line: import numpy...
The [vrad tutorial](http://halotools.readthedocs.io/en/latest/quickstart_and_tutorials/tutorials/catalog_analysis/galcat_analysis/basic_examples/velocity_statistics/galaxy_catalog_analysis_tutorial6.html) and [vdisp tutorial](http://halotools.readthedocs.io/en/latest/quickstart_and_tutorials/tutorials/catalog_analysis/galcat_analysis/basic_examples/velocity_statistics/galaxy_catalog_analysis_tutorial7.html) still do not contain anything about this new feature, nor do the docstrings, so the `normalize_rbins_by` feature is still mostly a hidden feature.
The mean occupation functions should have dedicated science-verification tests added prior to releasing v0.5
Defining scatter in an independent class is a bit convoluted because the functionality is so simple. After some experimenting with building models, reliance on this class does not really improve...