astroquery icon indicating copy to clipboard operation
astroquery copied to clipboard

Make empty results consistent for all modules

Open bsipocz opened this issue 8 years ago • 3 comments

Some of the modules returns an empty table when no result is found, while others (e.g. sdss) returns None.

bsipocz avatar Jul 02 '17 21:07 bsipocz

I think empty table should be the proper result, as it is more explicit than None. Also, I have a habit to make queries that purposely return empty tables just to check if the service is alive.

pllim avatar Jul 03 '17 13:07 pllim

Sure, I agree with that. Only run into the None in sdss (but it was a random rather than a systematic check), so it may be a remnant of its nonconformity.

bsipocz avatar Jul 03 '17 13:07 bsipocz

This is a sub of https://github.com/astropy/astroquery/issues/1838, and one that can be most quickly fixed (e.g. we already do something about the empty results, just not the right thing)

This should be done for the next release that is focusing on a lot of cleanup.

bsipocz avatar Dec 09 '22 23:12 bsipocz