FIX: incorrect parameter for JPL Horizons, changed 'BODY EQUATOR' -> 'BODY'
When querying the results of a JPL Horizons query via elements(refplane='body') the API returns this error:
ValueError: Query failed without known error message; received the following response:
API VERSION: 1.2
API SOURCE: NASA/JPL Horizons API
INPUT ERROR in VLADD in following line:
REF_PLANE=BODY EQUATOR
^ Too many constants
BATVAR: problem loading execution-control setting:
LINE=REF_PLANE=BODY EQUATOR
WLDINI: error loading execution-control file.
By changing the line in core.py from BODY EQUATOR to BODY, that API call works again.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.07%. Comparing base (
c522e2a) to head (96afeac). Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3370 +/- ##
=======================================
Coverage 70.07% 70.07%
=======================================
Files 232 232
Lines 19893 19893
=======================================
Hits 13940 13940
Misses 5953 5953
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Thanks, this fix looks good to me. As a side note, I thought that quoting "BODY EQUATOR" would fix the problem too, but it resulted in the same error, so this could be a Horizons bug or problem with their documentation. Regardless, the documentation does say that abbreviations are allowed, so I think this fix is correct.
@TheWand3rer Please add a change log entry.