astropy
Update URI in astroquery.imcce
What is the problem this feature will solve?
As the person responsible for the SkyBoT and Miriade services, I'd like to point out that the URI used by astroquery.imcce is deprecated.
Describe the desired outcome
Please update the URI:
http://vo.imcce.fr
to
https://ssp.imcce.fr
in the classes astroquery.imcce.SkybotClass and astroquery.imcce.MiriadeClass
Update also the documentation (partially done).
Additional context
No response
It seems like the module still works with the previous URL as expected, while we receive 404 errors with updating the URL, but keeping the code as is.
Could you please provide some more details, e.g. if the API has also been changed. Even better if you could open a PR with the proposed fixes. Thanks!
(E.g. I see this when parsing results for one the tests we have:
ipdb> response.raise_for_status()
*** requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://ssp.imcce.fr/webservices/skybot/skybotconesearch_query.php?-ra=0.0&-dec=0.0&-rd=0.3&-ep=2458291.893831018&-loc=G37&-filter=0.1&-objFilter=111&-refsys=EQJ2000&-output=all&-mime=text
)
Hi, I don't know which comparison changes I should choose to create a PR, in fact I don't know how to make a PR correctly.
Yes the vo.imcce.fr URI is still valid for a couple of months, after that it will not be.
The correct end-point of the Skybot.conesearch API is https://ssp.imcce.fr/webservices/skybot/api/conesearch.php? and for Miriade.ephemcc it is https://ssp.imcce.fr/webservices/miriade/api/ephemcc.php?
The arguments remain unchanged.
The skybot response now passes all our tests, but I run into issues with Miriade, namely that the response look totally different and therefore the parsing logic should be updated in the code, too. I'll have look into how complicated the update without knowing the expected behaviour/outputs. I may cc you on a PR that addresses this asking a review.