astroquery icon indicating copy to clipboard operation
astroquery copied to clipboard

jplhorizons remove deprecated columns in the code

Open ysBach opened this issue 1 year ago • 2 comments

There are a few deprecated columns that are no longer being queried, but remaining in the __init__.py:

https://github.com/astropy/astroquery/blob/9387c450137dd6ed0f9c2c96df4abfcf201059a8/astroquery/jplhorizons/init.py#L104-L113

I think it is safe to remove those lines because the HORIZONS no longer returns such columns...?

ysBach avatar Jan 02 '24 05:01 ysBach

I suppose these are not required but are still listed to ensure old code using them don't yet start failing, but @mkelley can correct me and point out if it's time for a cleanup.

bsipocz avatar Jan 04 '24 18:01 bsipocz

Yeah, they should get removed. I think the only drawback is that older cached files would fail. When was the change made? It might also require an update of the offline test files, depending on when those files where generated and when Horizons changed its output.

mkelley avatar Jan 11 '24 16:01 mkelley