astroquery icon indicating copy to clipboard operation
astroquery copied to clipboard

Refactor WFAU image retrieval to reject deprecated images

Open keflavich opened this issue 1 year ago • 4 comments

This refactor also adds a new method to retrieve the very useful metadata tables rather than just scrape them for download URLs.

Solves #2808

keflavich avatar Aug 13 '23 20:08 keflavich

Re "solves" - it's not a "magic" word, won't auto-close the issue. Please use fix, or close, or resolve instead :) https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

bsipocz avatar Aug 14 '23 22:08 bsipocz

local tests passing:

pytest astroquery/ukidss -x --pdb --remote-data
astroquery/ukidss/tests/test_ukidss.py ........                                                                                                                                                          
astroquery/ukidss/tests/test_ukidss_remote.py 	........                                                                                                                                                   

keflavich avatar Aug 15 '23 02:08 keflavich

The last failure I see here is in cadc, not wfau - is this real?

keflavich avatar Aug 15 '23 12:08 keflavich

The last failure I see here is in cadc, not wfau - is this real?

Opened #2811 for it. It looks consistent in CI, but I cannot yet reproduce it locally.

bsipocz avatar Aug 15 '23 17:08 bsipocz