astroquery
astroquery copied to clipboard
New hyperleda service 298
Hi all,
I am not sure if there has been any interest/progress on this, but since I already worked on this for my own projects, I decided to prepare a new class to query from HyperLEDA in relation to [#298].
I have followed closely the astropy's guidelines as well as the astroquery's template module to prepare the module and simple tests to match the astroquery API. I also placed a doc example in astroquery/docs/hyperleda/
All tests passed here, so, I hope it is in a decent shape for a review.
Hello @iskren-y-g! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Comment last updated at 2021-03-22 17:44:46 UTC
Codecov Report
Merging #2023 (3ac1663) into master (c4dde9d) will increase coverage by
2.58%
. The diff coverage is73.09%
.
@@ Coverage Diff @@
## master #2023 +/- ##
==========================================
+ Coverage 64.45% 67.03% +2.58%
==========================================
Files 200 416 +216
Lines 15930 27300 +11370
==========================================
+ Hits 10267 18300 +8033
- Misses 5663 9000 +3337
Impacted Files | Coverage Δ | |
---|---|---|
astroquery/hyperleda/tests/setup_package.py | 50.00% <50.00%> (ø) |
|
...stroquery/hyperleda/tests/test_hyperleda_remote.py | 50.00% <50.00%> (ø) |
|
astroquery/hyperleda/core.py | 57.69% <57.69%> (ø) |
|
astroquery/splatalogue/load_species_table.py | 89.47% <66.66%> (ø) |
|
astroquery/hyperleda/tests/test_hyperleda.py | 93.75% <93.75%> (ø) |
|
astroquery/simbad/core.py | 89.66% <95.00%> (+0.23%) |
:arrow_up: |
astroquery/hyperleda/__init__.py | 100.00% <100.00%> (ø) |
|
astroquery/sdss/core.py | 86.33% <100.00%> (ø) |
|
astroquery/sdss/tests/test_sdss.py | 94.57% <100.00%> (ø) |
|
astroquery/sha/core.py | 70.58% <100.00%> (ø) |
|
... and 262 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8248ba8...3ac1663. Read the comment docs.
Thanks for the contribution!
@low-sky, since you requested this long long ago, are you interested in reviewing this PR (or at least testing it out)?
Also, could you add a changelog entry?