astroquery icon indicating copy to clipboard operation
astroquery copied to clipboard

Esa documentation cleanup

Open tinuademargaret opened this issue 4 years ago • 3 comments
trafficstars

tinuademargaret avatar Feb 02 '21 16:02 tinuademargaret

Codecov Report

Merging #1970 (5ef6eeb) into main (74fb75d) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 5ef6eeb differs from pull request most recent head 81f9ef2. Consider uploading reports for the commit 81f9ef2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
- Coverage   62.92%   62.91%   -0.02%     
==========================================
  Files         133      133              
  Lines       17302    17307       +5     
==========================================
+ Hits        10888    10889       +1     
- Misses       6414     6418       +4     
Impacted Files Coverage Δ
astroquery/esa/hubble/core.py 86.47% <ø> (+0.35%) :arrow_up:
astroquery/astrometry_net/core.py 47.64% <0.00%> (-2.36%) :arrow_down:
astroquery/alma/core.py 43.35% <0.00%> (+0.55%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 08 '22 17:08 codecov[bot]

@ceb8 - could you squash the 4th (file deleting commit) into the 3rd one, to avoid the files showing up in the history in the first place?

bsipocz avatar Aug 08 '22 19:08 bsipocz

@ceb8 - could you squash the 4th (file deleting commit) into the 3rd one, to avoid the files showing up in the history in the first place?

Done.

ceb8 avatar Aug 10 '22 19:08 ceb8

Let me have a look at your comments @bsipocz, I will look for smaller datasets cc @esdc-esac-esa-int

jespinosaar avatar Aug 17 '22 12:08 jespinosaar

OK, so I did one minor cleanup, and as this passes the remote test, going ahead and merge it. I'll open a follow-up issue for using smaller datasets if possible to clean up the remaining example skips.

Thanks @ceb8!

bsipocz avatar Aug 17 '22 17:08 bsipocz