Thomas Robitaille

Results 891 comments of Thomas Robitaille

@larrybradley @keflavich - since I'm not a maintainer of the package, one of you should obviously have a look at this too, so once I've reviewed this and am happy...

@ayshih - thanks for the suggestions! I've now made sure that we catch the multi-character name case too, and if a single string does match the name of a multi-character...

A compromise to avoid any actual errors due to API change would be to deprecate the original keyword arguments unless they are also used for ipydatagrid. We could even translate...

@samaloney - in terms of intended behavior, we deliberately don't support a case of e.g. a Gaussian with no units on the parameters but called with a quantity with units...

@samaloney - ah I see, here is the function that dictates how units are dropped/added: https://github.com/astropy/astropy/blob/26bb3c061d3125e8c57530ae6a4f1f8483520cab/astropy/modeling/fitting.py#L197 It looks like if you fit a model with no units with data that...

In principle I would be on board with this, but I wonder if to avoid growing the list of acceptable inputs for reproject we should instead define a magic method...

Just to note that the spectral reprojection thing with the mismatching axes types is an issue which I will fix separately.

Last successful build of tests: https://github.com/astropy/reproject/actions/runs/10398602265 First failing one: https://github.com/astropy/reproject/actions/runs/10414456195

Changes in dependencies: ``` 2c2 < aiohappyeyeballs==2.3.5 --- > aiohappyeyeballs==2.3.6 29c29 < hypothesis==6.111.0 --- > hypothesis==6.111.1 60c60 < reproject @ file:///Users/runner/work/reproject/reproject/.tox/.tmp/package/1/reproject-0.14.1.dev8%2Bg7aaeb13a.tar.gz#sha256=c8bfb16dae88027ac4e0781f24d2bf9f84f90598892eea10d659f9d6b69caa32 --- > reproject @ file:///Users/runner/work/reproject/reproject/.tox/.tmp/package/1/reproject-0.14.1.dev8%2Bg7aaeb13a.tar.gz#sha256=fab9754e6ff7eaff955ad4de4ad2f4c97d806b56fb34793b61fa852f836c88d4 67c67 < sunpy==6.0.0 ---...

Looks like it's due to sunpy 6.0.1: https://github.com/astropy/reproject/pull/472